Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1985303002: Reland of iews: Initialize DesktopScreenX11::primary_display_index_. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, Tom Anderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of iews: Initialize DesktopScreenX11::primary_display_index_. (patchset #1 id:1 of https://codereview.chromium.org/1985283002/ ) Reason for revert: That patch couldn't have affected tests on Windows 7 since doesn't build on Windows. Original issue's description: > Revert of views: Initialize DesktopScreenX11::primary_display_index_. (patchset #1 id:1 of https://codereview.chromium.org/1983863003/ ) > > Reason for revert: > Speculative revert to see if reverting this affects the tests on Windows 7 (Dbg)(1) http://crbug.com/612523 > > Original issue's description: > > views: Initialize DesktopScreenX11::primary_display_index_. > > > > The new field was introduced in crrev.com/391625, but this field was left > > uninitialized in this ctor. > > > > BUG=42313 > > > > Committed: https://crrev.com/71017aa70fb2feaa60c8178e253b100969800b63 > > Cr-Commit-Position: refs/heads/master@{#393985} > > TBR=sky@chromium.org,sadrul@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=42313 > > Committed: https://crrev.com/e6688b1f2a74cd5055938f0fe05322ef011e7036 > Cr-Commit-Position: refs/heads/master@{#394266} TBR=sky@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=42313 Committed: https://crrev.com/b76a26ee084e10f34ca545fdd6088c96b759556f Cr-Commit-Position: refs/heads/master@{#394269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qyearsley
Created Reland of iews: Initialize DesktopScreenX11::primary_display_index_.
4 years, 7 months ago (2016-05-17 23:43:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985303002/1
4 years, 7 months ago (2016-05-17 23:43:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:44:14 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:45:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b76a26ee084e10f34ca545fdd6088c96b759556f
Cr-Commit-Position: refs/heads/master@{#394269}

Powered by Google App Engine
This is Rietveld 408576698