Chromium Code Reviews
DescriptionReland of iews: Initialize DesktopScreenX11::primary_display_index_. (patchset #1 id:1 of https://codereview.chromium.org/1985283002/ )
Reason for revert:
That patch couldn't have affected tests on Windows 7 since doesn't build on Windows.
Original issue's description:
> Revert of views: Initialize DesktopScreenX11::primary_display_index_. (patchset #1 id:1 of https://codereview.chromium.org/1983863003/ )
>
> Reason for revert:
> Speculative revert to see if reverting this affects the tests on Windows 7 (Dbg)(1) http://crbug.com/612523
>
> Original issue's description:
> > views: Initialize DesktopScreenX11::primary_display_index_.
> >
> > The new field was introduced in crrev.com/391625, but this field was left
> > uninitialized in this ctor.
> >
> > BUG=42313
> >
> > Committed: https://crrev.com/71017aa70fb2feaa60c8178e253b100969800b63
> > Cr-Commit-Position: refs/heads/master@{#393985}
>
> TBR=sky@chromium.org,sadrul@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=42313
>
> Committed: https://crrev.com/e6688b1f2a74cd5055938f0fe05322ef011e7036
> Cr-Commit-Position: refs/heads/master@{#394266}
TBR=sky@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=42313
Committed: https://crrev.com/b76a26ee084e10f34ca545fdd6088c96b759556f
Cr-Commit-Position: refs/heads/master@{#394269}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||