Promises: Make debug calls only when debugging

src/js/promise.js

Index: src/js/promise.js
diff --git a/src/js/promise.js b/src/js/promise.js
index 42b772bab1580883b53e8ff6d6ddac255af37da2..a3384b3069dbb2836f5db26edfa1de0ba38b57a8 100644
--- a/src/js/promise.js
+++ b/src/js/promise.js
@@ -85,12 +85,12 @@ var GlobalPromise = function Promise(resolver) {
   var callbacks = CreateResolvingFunctions(promise);
 
   try {
-    %DebugPushPromise(promise, Promise);
+    if (DEBUG_IS_ACTIVE) %DebugPushPromise(promise, Promise);

[Dan Ehrenberg, 2016/05/18 00:34:46]

Other functions in this file store DEBUG_IS_ACTIVE in a local variable in order
to do just one read. Could you do that here, since you have multiple reads in
the same function?

[gsathya, 2016/05/18 00:50:06]

I've used a local var called "debug_is_active" which is what some other
functions use. Let me know if you'd prefer a more descriptive name.

     resolver(callbacks.resolve, callbacks.reject);
   } catch (e) {
     %_Call(callbacks.reject, UNDEFINED, e);
   } finally {
-    %DebugPopPromise();
+    if (DEBUG_IS_ACTIVE) %DebugPopPromise();
   }
 
   return promise;
@@ -128,13 +128,13 @@ function PromiseDone(promise, status, value, promiseQueue) {
 
 function PromiseHandle(value, handler, deferred) {
   try {
-    %DebugPushPromise(deferred.promise, PromiseHandle);
+    if (DEBUG_IS_ACTIVE) %DebugPushPromise(deferred.promise, PromiseHandle);
     var result = handler(value);
     deferred.resolve(result);
   } catch (exception) {
     try { deferred.reject(exception); } catch (e) { }
   } finally {
-    %DebugPopPromise();
+    if (DEBUG_IS_ACTIVE) %DebugPopPromise();
   }
 }