Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1985283002: Revert of views: Initialize DesktopScreenX11::primary_display_index_. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, Tom Anderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of views: Initialize DesktopScreenX11::primary_display_index_. (patchset #1 id:1 of https://codereview.chromium.org/1983863003/ ) Reason for revert: Speculative revert to see if reverting this affects the tests on Windows 7 (Dbg)(1) http://crbug.com/612523 Original issue's description: > views: Initialize DesktopScreenX11::primary_display_index_. > > The new field was introduced in crrev.com/391625, but this field was left > uninitialized in this ctor. > > BUG=42313 > > Committed: https://crrev.com/71017aa70fb2feaa60c8178e253b100969800b63 > Cr-Commit-Position: refs/heads/master@{#393985} TBR=sky@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=42313 Committed: https://crrev.com/e6688b1f2a74cd5055938f0fe05322ef011e7036 Cr-Commit-Position: refs/heads/master@{#394266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
qyearsley
Created Revert of views: Initialize DesktopScreenX11::primary_display_index_.
4 years, 7 months ago (2016-05-17 23:18:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985283002/1
4 years, 7 months ago (2016-05-17 23:19:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:20:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6688b1f2a74cd5055938f0fe05322ef011e7036 Cr-Commit-Position: refs/heads/master@{#394266}
4 years, 7 months ago (2016-05-17 23:22:22 UTC) #5
sadrul
On 2016/05/17 23:18:27, qyearsley wrote: > Created Revert of views: Initialize DesktopScreenX11::primary_display_index_. It's an x11 ...
4 years, 7 months ago (2016-05-17 23:28:54 UTC) #6
qyearsley
On 2016/05/17 at 23:28:54, sadrul wrote: > On 2016/05/17 23:18:27, qyearsley wrote: > > Created ...
4 years, 7 months ago (2016-05-17 23:42:13 UTC) #7
qyearsley
4 years, 7 months ago (2016-05-17 23:43:06 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1985303002/ by qyearsley@chromium.org.

The reason for reverting is: That patch couldn't have affected tests on Windows
7 since doesn't build on Windows..

Powered by Google App Engine
This is Rietveld 408576698