Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1985173003: Adjust do visit in ExitDetector (Closed)

Created:
4 years, 7 months ago by srawlins
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust do visit in ExitDetector BUG=https://github.com/dart-lang/sdk/issues/26473 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cd34de9e0ea244933269eb5acea9763c67e1e3f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srawlins
This is here so I can address Brian's comment here: https://codereview.chromium.org/1943443002/diff/20001/pkg/analyzer/lib/src/generated/resolver.dart
4 years, 7 months ago (2016-05-17 21:12:45 UTC) #2
srawlins
On 2016/05/17 21:12:45, srawlins wrote: > This is here so I can address Brian's comment ...
4 years, 7 months ago (2016-05-17 21:13:43 UTC) #3
Brian Wilkerson
lgtm. I don't know of any reason why it wasn't doing this before.
4 years, 7 months ago (2016-05-17 21:59:48 UTC) #4
srawlins
4 years, 7 months ago (2016-05-18 00:12:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cd34de9e0ea244933269eb5acea9763c67e1e3f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698