Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1985163002: Remove GrFontScaler class (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@rmkey
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrFontScaler class. This class is now effectively a set of helpers for interacting with a SkGlyphCache by GrBatchTextStrike. The class is deleted and the code is made into static functions in GrBatchFontCache.cpp BUG=chromium:608566 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1985163002 Committed: https://skia.googlesource.com/skia/+/c2878e23d405e7ae77f6110602ad75ce1f6b941c

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : remove comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -326 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 4 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 4 chunks +9 lines, -11 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.h View 1 2 8 chunks +23 lines, -18 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 1 2 5 chunks +166 lines, -14 lines 1 comment Download
M src/gpu/text/GrFontScaler.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
M src/gpu/text/GrFontScaler.cpp View 1 1 chunk +0 lines, -179 lines 0 comments Download
M src/gpu/text/GrTextUtils.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 2 12 chunks +12 lines, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
bsalomon
https://codereview.chromium.org/1985163002/diff/40001/src/gpu/text/GrBatchFontCache.cpp File src/gpu/text/GrBatchFontCache.cpp (right): https://codereview.chromium.org/1985163002/diff/40001/src/gpu/text/GrBatchFontCache.cpp#newcode146 src/gpu/text/GrBatchFontCache.cpp:146: static inline GrMaskFormat get_packed_glyph_mask_format(const SkGlyph& glyph) { This code ...
4 years, 7 months ago (2016-05-17 19:11:04 UTC) #5
bungeman-skia
Looks like a lot less indirection going on. lgtm
4 years, 7 months ago (2016-05-17 19:33:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985163002/40001
4 years, 7 months ago (2016-05-17 19:57:25 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:18:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c2878e23d405e7ae77f6110602ad75ce1f6b941c

Powered by Google App Engine
This is Rietveld 408576698