Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1985153002: Delete shared/platform/osx/strnlen_osx.c. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Delete shared/platform/osx/strnlen_osx.c. strnlen is provided by the 10.7 SDK and higher, so it is no longer necessary to implement the function manually. BUG=chromium:599950 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/7975b186d213188b50bec674a83e45ab11a90cfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M src/shared/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/shared/platform/build.scons View 1 chunk +0 lines, -1 line 0 comments Download
D src/shared/platform/osx/strnlen_osx.c View 1 chunk +0 lines, -20 lines 0 comments Download
M src/shared/platform/platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Robert Sesek
4 years, 7 months ago (2016-05-17 18:16:49 UTC) #4
Mark Seaborn
LGTM
4 years, 7 months ago (2016-05-17 18:18:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985153002/1
4 years, 7 months ago (2016-05-17 18:31:56 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 19:36:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/7975b186d...

Powered by Google App Engine
This is Rietveld 408576698