Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 198513002: [webcrypto] Make the import algorithm a required parameter. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Make the import algorithm a required parameter. This applies to both importKey() and unwrapKey(). This matches the intended change in the spec, of dropping self-identifying JWK keys: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25036 BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M LayoutTests/crypto/importKey.html View 2 chunks +3 lines, -11 lines 0 comments Download
M LayoutTests/crypto/importKey-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebCrypto.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
6 years, 9 months ago (2014-03-13 02:44:08 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-17 17:23:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/198513002/1
6 years, 9 months ago (2014-03-17 17:23:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:43:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-17 17:43:59 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-17 19:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/198513002/1
6 years, 9 months ago (2014-03-17 19:21:28 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 19:52:49 UTC) #8
Message was sent while issue was closed.
Change committed as 169383

Powered by Google App Engine
This is Rietveld 408576698