Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1985123002:
Disable broken tests on 'LTO Linux' buildbot. (Closed)
DescriptionDisable broken tests on 'LTO Linux' buildbot.
These breakages are not related to LTO, and only happen in the official mode.
All of them are reported, and the tests will be reenabled after they are fixed.
BUG=612473, 612496, 612503, 612507
Committed: https://crrev.com/f7e3c42cc1d32437f3a9e7d0c9f5adecf92b43a5
Cr-Commit-Position: refs/heads/master@{#394201}
Patch Set 1 #Patch Set 2 : don't use gtest_filter #Messages
Total messages: 16 (4 generated)
krasin@google.com changed reviewers: + thakis@chromium.org
Are all the breakages new? The two failing tests I looked at looked like they hadn't been touched in a while. Or did you add these tests to the list of tests run on this bot very recently?
On 2016/05/17 17:47:08, Nico (vacation May 19 to 22) wrote: > Are all the breakages new? The two failing tests I looked at looked like they > hadn't been touched in a while. Or did you add these tests to the list of tests > run on this bot very recently? This bot was setup just yesterday. It runs in the official mode (as we want to launch LTO for the official build), and it seems to be the first official Linux buildbot to run these tests at all. Not surprisingly, they are broken. I reported all the failures and assigned owners. See more at https://crbug.com/612473
Ah, that explains it. I'm ok with this change, but I vaguely remember that --gtest_filter in json files causes some issue...yes, see "[chromium-dev] Using --gtest_filter to disable tests on "Cast Linux" bot breaks retries without patch". Maybe just remove these test suites completely until they're fixed?
(I don't think that issue would affect this bot, but using features that work in only some situations always seems dangerous)
On 2016/05/17 17:51:10, Nico (vacation May 19 to 22) wrote: > Ah, that explains it. I'm ok with this change, but I vaguely remember that > --gtest_filter in json files causes some issue...yes, see "[chromium-dev] Using > --gtest_filter to disable tests on "Cast Linux" bot breaks retries without > patch". Maybe just remove these test suites completely until they're fixed? Since it's an FYI bot, I don't think that breaking retries without patch is a big deal. At the same point, it's much easier to forget that there were test suites removed, if they are not in the file. Unfortunately, json does not support comments. Otherwise, I would have removed the tests and added TODOs. In other words: I would like to keep gtest_filter unless you feel strongly about this.
On 2016/05/17 17:51:44, Nico (vacation May 19 to 22) wrote: > (I don't think that issue would affect this bot, but using features that work in > only some situations always seems dangerous) This feature is sometimes necessary. For instance, I had to disable a single test case in content_browsertests due to https://crbug.com/601957, which takes forever to be fixed. I really like that the rest of the test cases in this large test suite are still green under CFI.
On 2016/05/17 17:58:18, krasin wrote: > On 2016/05/17 17:51:44, Nico (vacation May 19 to 22) wrote: > > (I don't think that issue would affect this bot, but using features that work > in > > only some situations always seems dangerous) > > This feature is sometimes necessary. For instance, I had to disable a single > test case in content_browsertests due to https://crbug.com/601957, which takes > forever to be fixed. I really like that the rest of the test cases in this large > test suite are still green under CFI. Hm, for my bots I always remove the suite completely and use that as a forcing function to motivate me to get things resolved sooner than forever. So far, this has worked every time. (If someone says "yes, we broke this, and it'll take forever to fix", then I'll ask them to revert their change.) But if you feel strongly about this, lgtm.
In this case, it's small test suites, so I don't feel strongly. I've removed cast_unittests and sandbox_linux_unittests completely. I have reenabled mojo_system_unittests, as there's a fix coming per https://crbug.com/612503#c3
The CQ bit was checked by krasin@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1985123002/#ps20001 (title: "don't use gtest_filter")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985123002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable broken tests on 'LTO Linux' buildbot. These breakages are not related to LTO, and only happen in the official mode. All of them are reported, and the tests will be reenabled after they are fixed. BUG=612473,612496,612503,612507 ========== to ========== Disable broken tests on 'LTO Linux' buildbot. These breakages are not related to LTO, and only happen in the official mode. All of them are reported, and the tests will be reenabled after they are fixed. BUG=612473,612496,612503,612507 Committed: https://crrev.com/f7e3c42cc1d32437f3a9e7d0c9f5adecf92b43a5 Cr-Commit-Position: refs/heads/master@{#394201} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f7e3c42cc1d32437f3a9e7d0c9f5adecf92b43a5 Cr-Commit-Position: refs/heads/master@{#394201} |
