Issue 1985103002: Revert "Fix capturing variables in optimized compilations"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1985103002: Revert "Fix capturing variables in optimized compilations" (Closed)

Created:
4 years, 7 months ago by rmacnak

Modified:
4 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix capturing variables in optimized compilations" This reverts commit 3968005cc8cc2509ac8e47fe2e5aa989569e43df. Broke optimization counter and precompilation bots. TBR=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/01e023263e121899f2cbeb83921a27885c7d44e2

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -74 lines)			Patch
M	runtime/vm/ast.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	4 chunks	+10 lines, -36 lines	0 comments	Download
D	tests/language/regress_26453_test.dart	View	1 chunk	+0 lines, -33 lines	0 comments	Download

Total messages: 3 (1 generated)

rmacnak

Committed patchset #1 (id:1) manually as 01e023263e121899f2cbeb83921a27885c7d44e2 (presubmit successful).

4 years, 7 months ago (2016-05-17 17:05:12 UTC) #2

Message was sent while issue was closed.

lgtm