Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1985093003: leak_detector: call transform() with back_inserter (Closed)

Created:
4 years, 7 months ago by Simon Que
Modified:
4 years, 7 months ago
Reviewers:
Will Harris, tzik
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

leak_detector: call transform() with back_inserter To grow the destination vector dynamically, std::back_inserter must be passed to std::transform(). There must also be enough space in the destination container before std::transform() can be called. Call reserve() first to avoid reallocations. BUG=chromium:611562 TEST=build successfully Committed: https://crrev.com/ba7c5f1c1f063f61a96d9749a55854760949c916 Cr-Commit-Position: refs/heads/master@{#394243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/metrics/leak_detector/leak_detector.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Simon Que
4 years, 7 months ago (2016-05-17 18:36:32 UTC) #2
tzik
lgtm
4 years, 7 months ago (2016-05-17 18:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985093003/1
4 years, 7 months ago (2016-05-17 20:47:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 22:19:03 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:20:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7c5f1c1f063f61a96d9749a55854760949c916
Cr-Commit-Position: refs/heads/master@{#394243}

Powered by Google App Engine
This is Rietveld 408576698