Issue 198503004: Merged r19693, r19694 into 3.23 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 198503004: Merged r19693, r19694 into 3.23 branch. (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.23

Visibility:
Public.

More Reviews

Description

Merged r19693, r19694 into 3.23 branch. Fix HConstants with Smi-ranged HeapNumber values Fix for failing asserts in HBoundsCheck code generation on x64: use proper cmp operation width instead of asserting that Integer32 values should be zero extended. Similar to chromium:345820. BUG=349878, 349465 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19982

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -28 lines)			Patch
M	src/hydrogen-instructions.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+21 lines, -14 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-349465.js	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-349878.js	View	1 chunk	+18 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r19982 (tree was closed).

Expand Messages | Collapse Messages