Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1985013002: [arm] Fix platform requirements for ldrd and strd. (Closed)

Created:
4 years, 7 months ago by jbramley
Modified:
4 years, 7 months ago
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix platform requirements for ldrd and strd. These instructions were available before V8's baseline (ARMv6). V8 can always assume that they're present. BUG= Committed: https://crrev.com/b5413f7e943dcb63058e31679988379c0f7f53bf Cr-Commit-Position: refs/heads/master@{#36280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbramley
4 years, 7 months ago (2016-05-17 08:52:58 UTC) #2
epertoso
lgtm
4 years, 7 months ago (2016-05-17 12:30:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985013002/1
4 years, 7 months ago (2016-05-17 12:36:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 13:25:06 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 13:26:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5413f7e943dcb63058e31679988379c0f7f53bf
Cr-Commit-Position: refs/heads/master@{#36280}

Powered by Google App Engine
This is Rietveld 408576698