Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 1984993002: Set patch project path correct for WebRTC. (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set patch project path correct for WebRTC. 'git apply' works on Git indexes, so it's not possible to apply a patch to src/third_party/webrtc with cwd=src/third_party. Instead, set the cwd to the correct dir and add an extra patch level using the new flag in https://codereview.chromium.org/1988583002/ This essentially reverts https://codereview.chromium.org/1977373002/ + sets the project path correctly to src/third_party/webrtc. BUG=438952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -205 lines) Patch
M recipe_modules/gclient/api.py View 1 chunk +0 lines, -6 lines 0 comments Download
M recipe_modules/gclient/config.py View 1 chunk +1 line, -3 lines 0 comments Download
M recipe_modules/gclient/example.py View 2 chunks +0 lines, -10 lines 0 comments Download
D recipe_modules/gclient/example.expected/tryserver_webrtc_patch.json View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_chromium
4 years, 7 months ago (2016-05-17 07:13:12 UTC) #2
tandrii(chromium)
LGTM
4 years, 7 months ago (2016-05-17 07:14:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984993002/1
4 years, 7 months ago (2016-05-17 07:14:26 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 07:17:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300616

Powered by Google App Engine
This is Rietveld 408576698