Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: tracing/tracing/metrics/system_health/first_paint_metric.html

Issue 1984973002: Ensure disk cache init to make PCV1_COLD results stable (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: does.not.exist Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/first_paint_metric.html
diff --git a/tracing/tracing/metrics/system_health/first_paint_metric.html b/tracing/tracing/metrics/system_health/first_paint_metric.html
index d3e154929496d15e51b0e50b4e4953b8689f74d4..2d4bcb52445d34c763e210ab857be9f49ea3386b 100644
--- a/tracing/tracing/metrics/system_health/first_paint_metric.html
+++ b/tracing/tracing/metrics/system_health/first_paint_metric.html
@@ -114,16 +114,15 @@ tr.exportTo('tr.metrics.sh', function() {
function prepareTelemetryInternalEventPredicate(rendererHelper) {
var ignoreRegions = [];
- var warmCacheStart;
+ var internalRegionStart;
rendererHelper.mainThread.asyncSliceGroup.iterateAllEventsInThisContainer(
() => true, function(slice) {
- if (slice.title === 'telemetry.internal.warmCache.start')
- warmCacheStart = slice.start;
- if (slice.title === 'telemetry.internal.warmCache.end') {
- var warmCacheTimedEvent = new tr.model.TimedEvent(warmCacheStart);
- warmCacheTimedEvent.duration = slice.end - warmCacheStart;
-
- ignoreRegions.push(warmCacheTimedEvent);
+ if (!!slice.title.match(/^telemetry\.internal\.[^.]*\.start$/))
+ internalRegionStart = slice.start;
+ if (!!slice.title.match(/^telemetry\.internal\.[^.]*\.end$/)) {
+ var timedEvent = new tr.model.TimedEvent(internalRegionStart);
+ timedEvent.duration = slice.end - internalRegionStart;
+ ignoreRegions.push(timedEvent);
}
}, this);

Powered by Google App Engine
This is Rietveld 408576698