Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3564)

Unified Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated README for ChooserController Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
diff --git a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
index b3d7241d59f6a47917c579b21da8db5e32f06f5e..54ab78096d147ddde35fb213acb2c8d0852007ff 100644
--- a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
+++ b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
@@ -13,7 +13,7 @@ class View;
}
class Browser;
-class ChooserBubbleController;
+class ChooserController;
class ChooserBubbleUiViewDelegate;
// ChooserBubbleUiView implements a chooser-based permission model,
@@ -21,7 +21,7 @@ class ChooserBubbleUiViewDelegate;
// for user to grant permission. It can be used by WebUsb, WebBluetooth.
class ChooserBubbleUiView : public BubbleUi {
public:
- ChooserBubbleUiView(Browser* browser, ChooserBubbleController* controller);
+ ChooserBubbleUiView(Browser* browser, ChooserController* controller);
sky 2016/05/17 21:10:45 Document ownership.
juncai 2016/05/19 23:29:14 Done.
~ChooserBubbleUiView() override;
// BubbleUi:
@@ -35,7 +35,7 @@ class ChooserBubbleUiView : public BubbleUi {
views::BubbleBorder::Arrow GetAnchorArrow();
Browser* browser_;
- ChooserBubbleController* controller_;
+ ChooserController* controller_;
ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;
};
sky 2016/05/17 21:10:45 nit: DISALLOW_...
juncai 2016/05/19 23:29:14 Done.

Powered by Google App Engine
This is Rietveld 408576698