chrome/chrome_browser_ui.gypi - Issue 1984923002: Refactor ChooserBubbleController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 66287e29688a3a5c0d41ea78584d2076fc26f01b..783187f969dabda52c94eb59b0c7b986faee09e2 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -1555,8 +1555,8 @@

'browser/ui/apps/directory_access_confirmation_dialog.h',

'browser/ui/blocked_content/app_modal_dialog_helper.cc',

'browser/ui/blocked_content/app_modal_dialog_helper.h',

- 'browser/ui/bluetooth/bluetooth_chooser_bubble_controller.cc',

- 'browser/ui/bluetooth/bluetooth_chooser_bubble_controller.h',

+ 'browser/ui/bluetooth/bluetooth_chooser_controller.cc',

+ 'browser/ui/bluetooth/bluetooth_chooser_controller.h',

'browser/ui/bluetooth/bluetooth_chooser_desktop.cc',

'browser/ui/bluetooth/bluetooth_chooser_desktop.h',

'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc',

@@ -1821,8 +1821,8 @@

'browser/ui/unload_controller.h',

'browser/ui/user_manager.cc',

'browser/ui/user_manager.h',

- 'browser/ui/website_settings/chooser_bubble_controller.cc',

- 'browser/ui/website_settings/chooser_bubble_controller.h',

+ 'browser/ui/website_settings/chooser_bubble_delegate.cc',

+ 'browser/ui/website_settings/chooser_bubble_delegate.h',

'browser/ui/website_settings/permission_bubble_manager.cc',

'browser/ui/website_settings/permission_bubble_manager.h',

'browser/ui/website_settings/permission_bubble_view.h',

@@ -3322,6 +3322,7 @@

'dependencies': [

'../components/components.gyp:bubble',

'../components/components.gyp:feedback_proto',

+ '../components/components.gyp:ui_chooser_controller',

'../device/bluetooth/bluetooth.gyp:device_bluetooth',

'../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',

'../third_party/libaddressinput/libaddressinput.gyp:libaddressinput_strings',