Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge issue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.h
diff --git a/chrome/browser/ui/webui/settings/people_handler.h b/chrome/browser/ui/webui/settings/people_handler.h
index d216dfb8069ae91bd424549d1d89ef80de0a4b13..ac6f8cde7f9b04f44c04ce5cdf1f62f33bd41a37 100644
--- a/chrome/browser/ui/webui/settings/people_handler.h
+++ b/chrome/browser/ui/webui/settings/people_handler.h
@@ -107,7 +107,6 @@ class PeopleHandler : public SettingsPageUIHandler,
// LoginUIService::LoginUI implementation.
void FocusUI() override;
- void CloseUI() override;
// SigninManagerBase::Observer implementation.
void GoogleSigninSucceeded(const std::string& account_id,
@@ -152,10 +151,6 @@ class PeopleHandler : public SettingsPageUIHandler,
signin_metrics::AccessPoint access_point);
#endif
- // A utility function to call before actually showing setup dialog. Makes sure
- // that a new dialog can be shown and sets flag that setup is in progress.
- bool PrepareSyncSetup();
-
// Displays spinner-only UI indicating that something is going on in the
// background.
// TODO(kochi): better to show some message that the user can understand what
@@ -165,14 +160,8 @@ class PeopleHandler : public SettingsPageUIHandler,
// Displays an error dialog which shows timeout of starting the sync backend.
void DisplayTimeout();
- // Returns true if this object is the active login object.
- bool IsActiveLogin() const;
-
- // If a wizard already exists, return true. Otherwise, return false.
- bool IsExistingWizardPresent();
-
- // If a wizard already exists, focus it and return true.
- bool FocusExistingWizardIfPresent();
+ // Closes the associated sync settings page.
+ void CloseUI();
// Pushes the updated sync prefs to JavaScript.
void PushSyncPrefs();
« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler.h ('k') | chrome/browser/ui/webui/settings/people_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698