chrome/browser/sync/sync_global_error_unittest.cc - Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge issue Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sync_error_notifier_ash_unittest.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_global_error_unittest.cc

diff --git a/chrome/browser/sync/sync_global_error_unittest.cc b/chrome/browser/sync/sync_global_error_unittest.cc

index c1d76d46027c9ac025c3d8ef2c306355a49c2324..e7af93fd458fd944c75aa2ea9434de100a672453 100644

--- a/chrome/browser/sync/sync_global_error_unittest.cc

+++ b/chrome/browser/sync/sync_global_error_unittest.cc

@@ -47,7 +47,6 @@ class FakeLoginUI : public LoginUIService::LoginUI {

private:

// Overridden from LoginUIService::LoginUI:

void FocusUI() override { ++focus_ui_call_count_; }

- void CloseUI() override {}

int focus_ui_call_count_;

};

« no previous file with comments | « chrome/browser/sync/sync_error_notifier_ash_unittest.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »