Clean up LoginUIService. Remove Singleton behavior from PeopleHandler

components/browser_sync/browser/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_sync/browser/profile_sync_service.h"
 
 #include <stddef.h>
 #include <cstddef>
 #include <map>
 #include <utility>
@@ skipping 1686 matching lines @@
 void ProfileSyncService::ChangePreferredDataTypes(
     syncer::ModelTypeSet preferred_types) {
 
   DVLOG(1) << "ChangePreferredDataTypes invoked";
   const syncer::ModelTypeSet registered_types = GetRegisteredDataTypes();
   // Will only enable those types that are registered and preferred.
   sync_prefs_.SetPreferredDataTypes(registered_types, preferred_types);
 
   // Now reconfigure the DTM.
   ReconfigureDatatypeManager();
+
+  NotifyObservers();

[Nicolas Zea, 2016/05/17 20:00:55]

Is this necessary? Configuration should notify the observer anyways.

[tommycli, 2016/05/17 23:23:22]

Hi, I added this because OnUserChoseDatatypes wasn't notifying the observers
previously.

I looked through the code for the ReconfigureDatatypeManager and it also didn't
look like there was any path that notified the observers. (Unless there was an
unrecoverable error)

 }
 
 syncer::ModelTypeSet ProfileSyncService::GetActiveDataTypes() const {
   if (!IsSyncActive() || !ConfigurationDone())
     return syncer::ModelTypeSet();
   const syncer::ModelTypeSet preferred_types = GetPreferredDataTypes();
   const syncer::ModelTypeSet failed_types =
       data_type_status_table_.GetFailedTypes();
   return Difference(preferred_types, failed_types);
 }
@@ skipping 815 matching lines @@
 }
 
 std::string ProfileSyncService::unrecoverable_error_message() const {
   return unrecoverable_error_message_;
 }
 
 tracked_objects::Location ProfileSyncService::unrecoverable_error_location()
     const {
   return unrecoverable_error_location_;
 }