Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: chrome/browser/sync/sync_error_notifier_ash_unittest.cc

Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge issue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/sync_global_error_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_error_notifier_ash.h" 5 #include "chrome/browser/sync/sync_error_notifier_ash.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 public: 65 public:
66 FakeLoginUI() : focus_ui_call_count_(0) {} 66 FakeLoginUI() : focus_ui_call_count_(0) {}
67 67
68 ~FakeLoginUI() override {} 68 ~FakeLoginUI() override {}
69 69
70 int focus_ui_call_count() const { return focus_ui_call_count_; } 70 int focus_ui_call_count() const { return focus_ui_call_count_; }
71 71
72 private: 72 private:
73 // LoginUIService::LoginUI: 73 // LoginUIService::LoginUI:
74 void FocusUI() override { ++focus_ui_call_count_; } 74 void FocusUI() override { ++focus_ui_call_count_; }
75 void CloseUI() override {}
76 75
77 int focus_ui_call_count_; 76 int focus_ui_call_count_;
78 }; 77 };
79 78
80 std::unique_ptr<KeyedService> BuildMockLoginUIService( 79 std::unique_ptr<KeyedService> BuildMockLoginUIService(
81 content::BrowserContext* profile) { 80 content::BrowserContext* profile) {
82 return base::WrapUnique(new FakeLoginUIService()); 81 return base::WrapUnique(new FakeLoginUIService());
83 } 82 }
84 83
85 class SyncErrorNotifierTest : public AshTestBase { 84 class SyncErrorNotifierTest : public AshTestBase {
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 SCOPED_TRACE("Not expecting notification since sync setup is incomplete"); 231 SCOPED_TRACE("Not expecting notification since sync setup is incomplete");
233 VerifySyncErrorNotifierResult( 232 VerifySyncErrorNotifierResult(
234 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, 233 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS,
235 false /* not signed in */, 234 false /* not signed in */,
236 false /* no error */); 235 false /* no error */);
237 } 236 }
238 } 237 }
239 238
240 } // namespace test 239 } // namespace test
241 } // namespace ash 240 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/sync_global_error_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698