Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 1984803002: Separate phishing/SE ads/ SE landing interstitial UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 101fa5b97495430a32a220672099acdf38941bad..8a2c707b98ad6a4de67b2cb768690497f2cf343d 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -542,10 +542,21 @@ std::string SafeBrowsingBlockingPage::GetMetricPrefix() const {
case SB_REASON_HARMFUL:
return primary_subresource ? "harmful_subresource" : "harmful";
case SB_REASON_PHISHING:
- return primary_subresource ? "phishing_subresource" : "phishing";
+ ThreatPatternType threat_pattern_type =
+ unsafe_resources_[0].threat_metadata.threat_pattern_type;
+ if (threat_pattern_type == ThreatPatternType::PHISHING ||
+ threat_pattern_type == ThreatPatternType::NONE)
+ return primary_subresource ? "phishing_subresource" : "phishing";
+ else if (threat_pattern_type == ThreatPatternType::SOCIAL_ENGINEERING_ADS)
+ return primary_subresource ? "social_engineering_ads_subresource"
+ : "social_engineering_ads";
+ else if (threat_pattern_type ==
+ ThreatPatternType::SOCIAL_ENGINEERING_LANDING)
+ return primary_subresource ? "social_engineering_landing_subresource"
+ : "social_engineering_landing";
}
NOTREACHED();
- return std::string();
+ return "unkown_metric_prefix";
}
// We populate a parallel set of metrics to differentiate some threat sources.
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698