Delete tmp_path_ at the end of the tests

Delete tmp_path_ at the end of the tests

BUG=612296
Committed: https://crrev.com/e4f9ac949175541f148eee4b11488c30b7177623
Cr-Commit-Position: refs/heads/master@{#394069}

[vakh (use Gerrit instead), 2016-05-16 22:59:03]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2016-05-17 01:08:23]

lgtm

[vakh (use Gerrit instead), 2016-05-17 06:27:52]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2016-05-17 06:28:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984763003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984763003/1

[commit-bot: I haz the power, 2016-05-17 06:32:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 06:33:51]

Description was changed from

==========
Delete tmp_path_ at the end of the tests

BUG=612296
==========

to

==========
Delete tmp_path_ at the end of the tests

BUG=612296

Committed: https://crrev.com/e4f9ac949175541f148eee4b11488c30b7177623
Cr-Commit-Position: refs/heads/master@{#394069}
==========

[commit-bot: I haz the power, 2016-05-17 06:33:52]

Patchset 1 (id:??) landed as
https://crrev.com/e4f9ac949175541f148eee4b11488c30b7177623
Cr-Commit-Position: refs/heads/master@{#394069}

[asanka, 2016-05-17 14:51:56]

asanka@chromium.org changed reviewers:
+ asanka@chromium.org

[asanka, 2016-05-17 14:51:56]

In general, it's best to avoid writing to the current directory, specially when
dealing with test isolation etc. The current directory may not be writeable.

A better setup is to use a base::ScopedTempDir to create a temporary directory
whenever the test needs to write somewhere. That way,
* the resulting path is entirely under the control of the test, and is known to
be writeable by the test binary,
* the resulting path is unique (i.e. the tests won't fail if there are
concurrent tests running)
* even if the test fails or crashes the files will still be cleaned up by the
platform at some point.

https://codereview.chromium.org/1984763003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

https://codereview.chromium.org/1984763003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:569:
base::DeleteFile(tmp_path_, false);
This won't be executed if any of the ASSERT_*s fail above.