Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984743003: Replace FX_WSTRC(L"xyz").c_str() with just L"xyz" (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FX_WSTRC(L"xyz").c_str() with just L"xyz" No need to make a WideStringC here at all. Committed: https://pdfium.googlesource.com/pdfium/+/b22504a8c589ff39a1d6eaa83dcd3ead454d3443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M xfa/fxfa/app/xfa_textlayout.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, quick review.
4 years, 7 months ago (2016-05-16 18:14:02 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-16 18:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984743003/1
4 years, 7 months ago (2016-05-16 18:18:55 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:41:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b22504a8c589ff39a1d6eaa83dcd3ead454d...

Powered by Google App Engine
This is Rietveld 408576698