Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1984743002: [Media Router WebUI] Add slight delay before requesting initial data for Mac. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Add slight delay before requesting initial data for Mac. From some investigation looking into the bottlenecks of initial open/load time of the Media Router dialog (see comment 15), waiting a short amount of time before requesting data speeds up the data request time by over 15x. It would be good to see if this change is also reflected in the performance tests in the lab. BUG=599693 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5c14299c1f3b0ff1926b9e05607afd96cfadd809 Cr-Commit-Position: refs/heads/master@{#393990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/media_router/media_router.js View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks!
4 years, 7 months ago (2016-05-16 17:19:14 UTC) #4
imcheng
lgtm
4 years, 7 months ago (2016-05-16 22:55:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984743002/1
4 years, 7 months ago (2016-05-17 00:11:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 00:18:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 00:19:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c14299c1f3b0ff1926b9e05607afd96cfadd809
Cr-Commit-Position: refs/heads/master@{#393990}

Powered by Google App Engine
This is Rietveld 408576698