Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1984733003: Don't use SDK summaries with embedders (#26448). (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use SDK summaries with embedders (#26448). Addresses the issue seen in https://github.com/dart-lang/sdk/issues/26448. Ultimately we want a better story for summaries in the presence of embedded SDKs; in the short-term this simply disables them. The trick (and reason for all of the changes here) is that there is *a lot* of temporal coupling in the initiailization of contexts, sdks, resolvers, etc. With this change, embedder processing is pulled out to where it can be done before the SDK is configured. Hopefully this even makes this a bit more clear as resolver setup is less complex. Open question: I think the logic that calls `pub list-dirs` is dead and can safely be removed. Comments there welcome. Thanks! BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7937623063bfafeab253ee0dbaa1759a5e1ffc7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -52 lines) Patch
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 10 chunks +89 lines, -52 lines 0 comments Download
M pkg/analyzer_cli/test/all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/embedder_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-16 19:59:26 UTC) #2
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-16 20:33:46 UTC) #3
scheglov
lgtm
4 years, 7 months ago (2016-05-16 20:35:33 UTC) #4
pquitslund
4 years, 7 months ago (2016-05-16 21:13:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7937623063bfafeab253ee0dbaa1759a5e1ffc7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698