Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1984723005: Reland of Add rudimentary shelf delegate mus unit test. (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
msw, sadrul, sky
CC:
chromium-reviews, James Cook, kalyank, mfomitchev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add rudimentary shelf delegate mus unit test. (patchset #1 id:1 of https://codereview.chromium.org/1979103002/ ) Reason for revert: Still need to wait until Friday before we can land https://codereview.chromium.org/1975073002 and be completely shutdown-race-free, but a few other lingering races have been fixed since this first landed. Going to attempt to reland and see if bots are happy. Original issue's description: > Revert of Add rudimentary shelf delegate mus unit test. (patchset #6 id:180001 of https://codereview.chromium.org/1953893003/ ) > > Reason for revert: > Boo, sorry, looks like they're timing out on the bot :( > > Original issue's description: > > Add rudimentary shelf delegate mus unit test. > > > > Add simple mash shelf tests: > > - ash_sysui (which hosts the shelf) draws a window. > > - simple use of ShelfController/ShelfObserver interfaces. > > > > BUG=557406 > > TEST=Tests pass > > R=sky@chromium.org > > > > Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088 > > Cr-Commit-Position: refs/heads/master@{#393700} > > TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=557406 > > Committed: https://crrev.com/b63fb3d3eca89c99c2f387295f5d22ab32e6a650 > Cr-Commit-Position: refs/heads/master@{#393763} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557406 Committed: https://crrev.com/0da14dbf44cbc97a525ee1d72a4faf4fd7798c29 Cr-Commit-Position: refs/heads/master@{#393980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A ash/mus/shelf_delegate_mus_unittest.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/unittests_manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Ken Rockot(use gerrit already)
Created Reland of Add rudimentary shelf delegate mus unit test.
4 years, 7 months ago (2016-05-16 22:07:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984723005/1
4 years, 7 months ago (2016-05-16 22:08:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984723005/1
4 years, 7 months ago (2016-05-16 22:31:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/148923)
4 years, 7 months ago (2016-05-16 22:53:07 UTC) #5
Ken Rockot(use gerrit already)
Hmm looks like new failures
4 years, 7 months ago (2016-05-16 22:56:47 UTC) #6
sadrul
On 2016/05/16 22:56:47, Ken Rockot wrote: > Hmm looks like new failures Those crashes in ...
4 years, 7 months ago (2016-05-16 23:00:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984723005/1
4 years, 7 months ago (2016-05-16 23:07:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 23:43:36 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0da14dbf44cbc97a525ee1d72a4faf4fd7798c29 Cr-Commit-Position: refs/heads/master@{#393980}
4 years, 7 months ago (2016-05-16 23:46:04 UTC) #12
Ken Rockot(use gerrit already)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1982213002/ by rockot@chromium.org. ...
4 years, 7 months ago (2016-05-17 04:05:09 UTC) #13
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-17 04:05:19 UTC) #14
Message was sent while issue was closed.
On 2016/05/17 at 04:05:09, Ken Rockot wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1982213002/ by rockot@chromium.org.
> 
> The reason for reverting is: Hmm - still breaking stuff, but it doesn't look
like hangs. Instead, crashes in tcmalloc via skia.

And for more context.

0516/210042:ERROR:layer_tree_host_impl.cc(2223)] Forcing zero-copy tile
initialization as worker context is missing
../../third_party/tcmalloc/chromium/src/tcmalloc.cc:289] Attempt to free invalid
pointer 0x11b703c2d000 
Received signal 11 SEGV_MAPERR 000000000039
#0 0x00000053f0b7 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7ff59ce53cb0 <unknown>
#2 0x00000042de90 <unknown>
#3 0x000000431123 tcmalloc::Log()
#4 0x000000437ca0 (anonymous namespace)::do_free_with_callback()
#5 0x7ff5996d1cb0 SkMallocPixelRef::~SkMallocPixelRef()
#6 0x7ff5996d1cd9 SkMallocPixelRef::~SkMallocPixelRef()
#7 0x7ff5996303cb SkBitmap::freePixels()
#8 0x7ff5996368d7 SkBitmapDevice::~SkBitmapDevice()
#9 0x7ff599662530 DeviceCM::~DeviceCM()
#10 0x7ff59966050d SkCanvas::internalRestore()
#11 0x7ff599661234 SkCanvas::restore()
#12 0x7ff5999039ec SkBitmapOperations::CreateDropShadow()
#13 0x7ff59990cf5c gfx::(anonymous
namespace)::DropShadowSource::GetImageForScale()
#14 0x7ff5998fdc59 gfx::internal::ImageSkiaStorage::FindRepresentation()
#15 0x7ff5998fe7e0 gfx::ImageSkia::GetRepresentation()
#16 0x7ff59990a5c5 gfx::Canvas::DrawImageInt()
#17 0x7ff5999098b9 gfx::Canvas::DrawImageInt()
#18 0x7ff599c91610 views::ImageView::OnPaintImage()
#19 0x7ff599c914fa views::ImageView::OnPaint()
#20 0x7ff599cc16c0 views::View::Paint()
#21 0x7ff599b50e8d ui::Layer::PaintContentsToDisplayList()
#22 0x7ff599b50fbd ui::Layer::PaintContentsToDisplayList()
#23 0x7ff599bc8e4e cc::RecordingSource::UpdateAndExpandInvalidation()
#24 0x7ff599b8131a cc::PictureLayer::Update()
#25 0x7ff599c1fdfa cc::LayerTreeHost::DoUpdateLayers()
#26 0x7ff599c1fb06 cc::LayerTreeHost::UpdateLayers()
#27 0x7ff599c4fef1 cc::SingleThreadProxy::DoBeginMainFrame()
#28 0x7ff599c50aaf cc::SingleThreadProxy::BeginMainFrame()
#29 0x7ff599af6533
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN2ui17EventFactoryEvdevEFvRKNS6_16PinchEventParamsEEEEFvPS7_SA_EJRNS_7WeakPtrIS7_EESA_EEENS0_12InvokeHelperILb1EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE
#30 0x7ff599e45e99 base::debug::TaskAnnotator::RunTask()
#31 0x7ff599e55fc5 base::MessageLoop::RunTask()
#32 0x7ff599e562b8 base::MessageLoop::DeferOrRunPendingTask()
#33 0x7ff599e565db base::MessageLoop::DoWork()
#34 0x7ff599e57c5d base::MessagePumpDefault::Run()
#35 0x7ff599e55b4d base::MessageLoop::RunHandler()
#36 0x7ff599e66300 base::RunLoop::Run()
#37 0x7ff599e19f1b shell::ApplicationRunner::Run()
#38 0x7ff599e19fcc shell::ApplicationRunner::Run()
#39 0x7ff5993f6e3b MojoMain
#40 0x0000004f6c47 shell::RunNativeApplication()
#41 0x0000004f43a0 shell::(anonymous namespace)::RunNativeLibrary()
#42 0x0000004f473a
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIPFvPvN4mojo16InterfaceRequestIN5shell5mojom11ShellClientEEEEEESD_JRS6_EEENS0_12InvokeHelperILb0EvSF_EEFvSC_EE3RunEPNS0_13BindStateBaseEOSC_
#43 0x0000004f667f shell::ChildProcessMain()
#44 0x0000004f42c5 shell::ChildProcessMain()
#45 0x00000042d8c7 main
#46 0x7ff59b23376d __libc_start_main
#47 0x000000411391 <unknown>

Powered by Google App Engine
This is Rietveld 408576698