Chromium Code Reviews
DescriptionReland of Add rudimentary shelf delegate mus unit test. (patchset #1 id:1 of https://codereview.chromium.org/1979103002/ )
Reason for revert:
Still need to wait until Friday before we can land https://codereview.chromium.org/1975073002 and be completely shutdown-race-free, but a few other lingering races have been fixed since this first landed. Going to attempt to reland and see if bots are happy.
Original issue's description:
> Revert of Add rudimentary shelf delegate mus unit test. (patchset #6 id:180001 of https://codereview.chromium.org/1953893003/ )
>
> Reason for revert:
> Boo, sorry, looks like they're timing out on the bot :(
>
> Original issue's description:
> > Add rudimentary shelf delegate mus unit test.
> >
> > Add simple mash shelf tests:
> > - ash_sysui (which hosts the shelf) draws a window.
> > - simple use of ShelfController/ShelfObserver interfaces.
> >
> > BUG=557406
> > TEST=Tests pass
> > R=sky@chromium.org
> >
> > Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088
> > Cr-Commit-Position: refs/heads/master@{#393700}
>
> TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=557406
>
> Committed: https://crrev.com/b63fb3d3eca89c99c2f387295f5d22ab32e6a650
> Cr-Commit-Position: refs/heads/master@{#393763}
TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=557406
Committed: https://crrev.com/0da14dbf44cbc97a525ee1d72a4faf4fd7798c29
Cr-Commit-Position: refs/heads/master@{#393980}
Patch Set 1 #
Messages
Total messages: 14 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||