Support setReadTimeout in CronetHttpURLConnection

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
index 1575a696d504f4efa0b8813d9a2f5ffd485d9304..6b421d7de42d5a34a217bb94702406018869ade2 100644
--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
@@ -405,7 +405,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {
      */
     void getMoreData(ByteBuffer byteBuffer) throws IOException {
         mRequest.read(byteBuffer);
-        mMessageLoop.loop();
+        mMessageLoop.loop(getReadTimeout());
     }
 
     /**
@@ -516,7 +516,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {
         if (!mHasResponse) {
             startRequest();
             // Blocks until onResponseStarted or onFailed is called.
-            mMessageLoop.loop();
+            mMessageLoop.loop(getConnectTimeout());

[rohitagr, 2016/05/16 17:21:56]

I don't think this is safe: as I understand it, the connect timeout is supposed
to cap the amount of time it takes to establish the TCP connection, rather than
the amount of time it takes to get the headers.

[xunjieli, 2016/05/16 17:28:10]

Yea, although the specs is pretty vague about what is a connect timeout. "Sets
the maximum time in milliseconds to wait while connecting."
I think this is a good proxy, although I don't really know what values users of
HttpURLConnection are setting as the connect timeout. If the often-used values
are very short, I agree that doing this is probably not safe.

[kapishnikov, 2016/05/17 20:33:24]

Following up the Helen's PS4 change. I think the good approximation here would
be getConnectTimeout() +
getReadTimeout() value as the timeout (upper bound). That is what actually can
happen here, i.e. establishing the connection and reading the headers. This is
true even if connect() method is called before, since connect() method in Cronet
does not guarantee that the connection was actually established.

             mHasResponse = true;
         }
         checkHasResponse();