Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 1984723002: Support setReadTimeout in CronetHttpURLConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address John's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index 9bf82b51ce196569e808f8395e784d17c27d66fb..43cc4a120e23f16bfedaa27895acf3c3cf104429 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -23,6 +23,7 @@ import java.io.OutputStream;
import java.lang.reflect.Method;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
+import java.net.SocketTimeoutException;
import java.net.URL;
import java.util.ArrayList;
import java.util.Arrays;
@@ -91,6 +92,42 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
+ @OnlyRunCronetHttpURLConnection
+ public void testConnectTimeout() throws Exception {
+ // Add url interceptors.
+ MockUrlRequestJobFactory.setUp();
+ URL url = new URL(MockUrlRequestJobFactory.getMockUrlForHangingConnect());
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+ connection.setConnectTimeout(1000);
+ try {
+ connection.getResponseCode();
+ fail();
+ } catch (SocketTimeoutException e) {
+ // Expected
+ }
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ @OnlyRunCronetHttpURLConnection
+ public void testReadTimeout() throws Exception {
+ // Add url interceptors.
+ MockUrlRequestJobFactory.setUp();
+ URL url = new URL(MockUrlRequestJobFactory.getMockUrlForHangingRead());
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+ connection.setReadTimeout(1000);
+ assertEquals(200, connection.getResponseCode());
+ InputStream in = connection.getInputStream();
+ try {
+ in.read();
+ fail();
+ } catch (SocketTimeoutException e) {
+ // Expected
+ }
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
@CompareDefaultWithCronet
// Regression test for crbug.com/571436.
public void testDefaultToPostWhenDoOutput() throws Exception {

Powered by Google App Engine
This is Rietveld 408576698