components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java - Issue 1984723002: Support setReadTimeout in CronetHttpURLConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Issue 1984723002: Support setReadTimeout in CronetHttpURLConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address John's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/urlconnection/MessageLoop.java » ('j') | components/cronet/android/java/src/org/chromium/net/urlconnection/MessageLoop.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

index 1575a696d504f4efa0b8813d9a2f5ffd485d9304..c626b70e21901f9d88eaff74e3df221dcf29ee30 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

@@ -405,7 +405,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {

void getMoreData(ByteBuffer byteBuffer) throws IOException {

mRequest.read(byteBuffer);

- mMessageLoop.loop();

+ mMessageLoop.loop(getReadTimeout());

}

/**

@@ -516,7 +516,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {

if (!mHasResponse) {

startRequest();

// Blocks until onResponseStarted or onFailed is called.

- mMessageLoop.loop();

+ mMessageLoop.loop(getConnectTimeout() + getReadTimeout());

mHasResponse = true;

}

checkHasResponse();