Support setReadTimeout in CronetHttpURLConnection

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
 import android.util.Pair;
 
 import org.chromium.base.Log;
 import org.chromium.net.CronetEngine;
@@ skipping 378 matching lines @@
 
     /**
      * Returns whether this connection uses a proxy server.
      */
     @Override
     public boolean usingProxy() {
         // TODO(xunjieli): implement this.
         return false;
     }
 
+    @Override
+    public void setConnectTimeout(int timeout) {
+        // Per-request connect timeout is not supported because of late binding.
+        // Sockets are assigned to requests according to request priorities
+        // when sockets are connected. This requires requests with the same host,
+        // domain and port to have same timeout.
+        throw new UnsupportedOperationException("Not supported");

[pauljensen, 2016/05/19 00:51:59]

I'm not sure throwing an exception here is what we want to do.  I think
generally for compatibility layers, where the goal is to allow old apps to use
new technology, we should log an error but not throw an exception for
functionality that isn't required for general use.  This way embedders can try
out Cronet without having to modify their code, at least for the common use case
where timeouts are not hit.

This is essentially what we do for things like:
1. trying to use the HTTP cache with our HttpURLConnection API impl
2. ten different JavaCronetEngine functions

By throwing an exception here Cronet no longer becomes a drop in replacement
they can try out.

Anyhow, this is just my 2 cents.

+    }
+
     /**
      * Used by {@link CronetInputStream} to get more data from the network
      * stack. This should only be called after the request has started. Note
      * that this call might block if there isn't any more data to be read.
      * Since byteBuffer is passed to the UrlRequest, it must be a direct
      * ByteBuffer.
      */
     void getMoreData(ByteBuffer byteBuffer) throws IOException {
         mRequest.read(byteBuffer);
-        mMessageLoop.loop();
+        mMessageLoop.loop(getReadTimeout());
     }
 
     /**
      * Returns the index of request header in {@link #mRequestHeaders} or
      * -1 if not found.
      */
     private int findRequestProperty(String key) {
         for (int i = 0; i < mRequestHeaders.size(); i++) {
             Pair<String, String> entry = mRequestHeaders.get(i);
             if (entry.first.equalsIgnoreCase(key)) {
@@ skipping 169 matching lines @@
             // Strips Content-Encoding response header. See crbug.com/592700.
             if (!entry.getKey().equalsIgnoreCase("Content-Encoding")) {
                 mResponseHeadersList.add(
                         new AbstractMap.SimpleImmutableEntry<String, String>(entry));
             }
         }
         mResponseHeadersList = Collections.unmodifiableList(mResponseHeadersList);
         return mResponseHeadersList;
     }
 }