Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1984713002: Use elf.h inside the package. (Closed)

Created:
4 years, 7 months ago by yunlian
Modified:
4 years, 7 months ago
Reviewers:
michaelbai, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use elf.h inside the package. MAC does not have elf.h, so use the elf.h inside the package instead of the one in the system. One failure example is https://codereview.chromium.org/1978803003/ TEST=make; make check BUG= R=michaelbai@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/9eb2c6fe6caacdc2c063274ca4d81aa7a4633143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/common/dwarf/elf_reader.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
yunlian
ping?
4 years, 7 months ago (2016-05-18 19:41:56 UTC) #3
michaelbai
lgtm
4 years, 7 months ago (2016-05-18 19:45:04 UTC) #4
yunlian
Committed patchset #1 (id:1) manually as 9eb2c6fe6caacdc2c063274ca4d81aa7a4633143 (presubmit successful).
4 years, 7 months ago (2016-05-18 19:56:26 UTC) #6
michaelbai
4 years, 7 months ago (2016-05-18 21:24:17 UTC) #7
Message was sent while issue was closed.
still failed on mac

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_...

Powered by Google App Engine
This is Rietveld 408576698