Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 1984663002: Remove mode-transition in TextTrack::setKind (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrack.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.cpp b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
index 7b8f05abab3a28943bdf6ea90bf8150f744f9078..c1112a418d9a66847140f82141e10de8ea5702ab 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrack.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
@@ -142,17 +142,6 @@ bool TextTrack::isVisualKind() const
return kind() == subtitlesKeyword() || kind() == captionsKeyword();
}
-void TextTrack::setKind(const AtomicString& newKind)
-{
- AtomicString oldKind = kind();
- TrackBase::setKind(newKind);
-
- // If kind changes from visual to non-visual and mode is 'showing', then force mode to 'hidden'.
- // FIXME: This is not per spec. crbug.com/460923
- if (oldKind != kind() && mode() == showingKeyword() && !isVisualKind())
- setMode(hiddenKeyword());
-}
-
void TextTrack::setMode(const AtomicString& mode)
{
ASSERT(mode == disabledKeyword() || mode == hiddenKeyword() || mode == showingKeyword());
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.h ('k') | third_party/WebKit/Source/core/html/track/TrackBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698