Remove mode-transition in TextTrack::setKind

Remove mode-transition in TextTrack::setKind

This mode-transition gives rise to inconsistent state-updates, and isn't
specified [1]. Remove it, and with it the setKind override.

Also move all the mutators to TextTrack since that's the only type of
track where these fields can be mutated (and only if sourced via a
HTMLTrackElement.)

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-track-kind

BUG=460923, 608772
Committed: https://crrev.com/aea239459e30190050f8897b6e5b2b9856d2de4f
Cr-Commit-Position: refs/heads/master@{#394122}

[fs, 2016-05-16 12:38:48]

Description was changed from

==========
Remove mode-transition in TextTrack::setKind

This mode-transition gives rise to inconsistent state-updates, and isn't
specified. Remove it, and with it the setKind override.

Also move all the mutators to TextTrack since that's the only type of
track where these fields can be mutated (and only if sourced via a
HTMLTrackElement.)

BUG=460923,608772
==========

to

==========
Remove mode-transition in TextTrack::setKind

This mode-transition gives rise to inconsistent state-updates, and isn't
specified [1]. Remove it, and with it the setKind override.

Also move all the mutators to TextTrack since that's the only type of
track where these fields can be mutated (and only if sourced via a
HTMLTrackElement.)

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-track-kind

BUG=460923,608772
==========

[fs, 2016-05-16 13:27:50]

fs@opera.com changed reviewers:
+ davve@opera.com

[fs, 2016-05-16 13:27:50]

This does away with this unwanted mode-transition altogether - if we end up
wanting something like this behavior, then it should probably be in the form of
detecting a visual<->non-visual transition and then hiding/showing the track as
needed. (Which will likely be similar in many ways to what TextTrack::setMode
does, but not mutating 'mode'.)

[davve, 2016-05-17 12:55:47]

lgtm

[fs, 2016-05-17 13:02:28]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-17 13:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984663002/1

[commit-bot: I haz the power, 2016-05-17 14:38:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 14:39:14]

Description was changed from

==========
Remove mode-transition in TextTrack::setKind

This mode-transition gives rise to inconsistent state-updates, and isn't
specified [1]. Remove it, and with it the setKind override.

Also move all the mutators to TextTrack since that's the only type of
track where these fields can be mutated (and only if sourced via a
HTMLTrackElement.)

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-track-kind

BUG=460923,608772
==========

to

==========
Remove mode-transition in TextTrack::setKind

This mode-transition gives rise to inconsistent state-updates, and isn't
specified [1]. Remove it, and with it the setKind override.

Also move all the mutators to TextTrack since that's the only type of
track where these fields can be mutated (and only if sourced via a
HTMLTrackElement.)

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-track-kind

BUG=460923,608772

Committed: https://crrev.com/aea239459e30190050f8897b6e5b2b9856d2de4f
Cr-Commit-Position: refs/heads/master@{#394122}
==========

[commit-bot: I haz the power, 2016-05-17 14:39:18]

Patchset 1 (id:??) landed as
https://crrev.com/aea239459e30190050f8897b6e5b2b9856d2de4f
Cr-Commit-Position: refs/heads/master@{#394122}