Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1984663002: Remove mode-transition in TextTrack::setKind (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, gasubic, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mode-transition in TextTrack::setKind This mode-transition gives rise to inconsistent state-updates, and isn't specified [1]. Remove it, and with it the setKind override. Also move all the mutators to TextTrack since that's the only type of track where these fields can be mutated (and only if sourced via a HTMLTrackElement.) [1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-track-kind BUG=460923, 608772 Committed: https://crrev.com/aea239459e30190050f8897b6e5b2b9856d2de4f Cr-Commit-Position: refs/heads/master@{#394122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -25 lines) Patch
M third_party/WebKit/Source/core/html/track/TextTrack.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
This does away with this unwanted mode-transition altogether - if we end up wanting something ...
4 years, 7 months ago (2016-05-16 13:27:50 UTC) #3
davve
lgtm
4 years, 7 months ago (2016-05-17 12:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984663002/1
4 years, 7 months ago (2016-05-17 13:02:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 14:38:18 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 14:39:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aea239459e30190050f8897b6e5b2b9856d2de4f
Cr-Commit-Position: refs/heads/master@{#394122}

Powered by Google App Engine
This is Rietveld 408576698