Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984623002: Add test case for WebRTC patch on Chromium trybots. (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add test case for WebRTC patch on Chromium trybots. Depends on https://codereview.chromium.org/1976243002/ BUG=438952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300590

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated expectations for https://codereview.chromium.org/1976243002/#ps40001 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 1 chunk +8 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json View 1 5 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
kjellander_chromium
4 years, 7 months ago (2016-05-16 08:24:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984623002/1
4 years, 7 months ago (2016-05-16 08:25:09 UTC) #4
tandrii(chromium)
https://codereview.chromium.org/1984623002/diff/1/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json File scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json (right): https://codereview.chromium.org/1984623002/diff/1/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json#newcode24 scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json:24: "src\\third_party", good https://codereview.chromium.org/1984623002/diff/1/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json#newcode40 scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json:40: "src/third_party@HEAD", bad :(
4 years, 7 months ago (2016-05-16 08:28:05 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4828)
4 years, 7 months ago (2016-05-16 08:32:10 UTC) #7
kjellander_chromium
PTAL https://codereview.chromium.org/1984623002/diff/1/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json File scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json (right): https://codereview.chromium.org/1984623002/diff/1/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json#newcode40 scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json:40: "src/third_party@HEAD", On 2016/05/16 08:28:05, tandrii(chromium)-traveling wrote: > bad ...
4 years, 7 months ago (2016-05-16 08:34:39 UTC) #8
tandrii(chromium)
LGTM so now we don't sync webrtc, but better than nothing.
4 years, 7 months ago (2016-05-16 08:38:02 UTC) #9
kjellander_chromium
On 2016/05/16 08:38:02, tandrii(chromium)-traveling wrote: > LGTM > > so now we don't sync webrtc, ...
4 years, 7 months ago (2016-05-16 08:41:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984623002/20001
4 years, 7 months ago (2016-05-16 09:03:19 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 09:06:57 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300590

Powered by Google App Engine
This is Rietveld 408576698