Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 19846006: Use const path in SkPathContainsPoint (Closed)

Created:
7 years, 5 months ago by Savago-old
Modified:
7 years, 5 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, dglazkov+blink, Rik, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Treat received Path as a const. Skia internally will either create a new Path object in a call to 'transform' or can do it inplace if the destination pointer is the same as the source. By copying the Path object on start, we can treat the received Path as a const reference instead of a pointer and save 2 function calls to set/restore the fill type. BUG=236559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154713

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M Source/core/platform/graphics/Path.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/skia/SkiaUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/SkiaUtils.cpp View 2 chunks +6 lines, -10 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Savago-old
7 years, 5 months ago (2013-07-23 00:13:07 UTC) #1
eseidel
7 years, 5 months ago (2013-07-23 00:25:51 UTC) #2
pdr.
LGTM Please update the patch title to be a little more descriptive. Maybe "Use const ...
7 years, 5 months ago (2013-07-23 00:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@partner.samsung.com/19846006/1
7 years, 5 months ago (2013-07-23 00:34:11 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 03:12:47 UTC) #5
Message was sent while issue was closed.
Change committed as 154713

Powered by Google App Engine
This is Rietveld 408576698