Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: chrome/browser/net/predictor_browsertest.cc

Issue 1984583002: Fix a predictor browsertest for the PreconnectMore experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor_browsertest.cc
diff --git a/chrome/browser/net/predictor_browsertest.cc b/chrome/browser/net/predictor_browsertest.cc
index 2afa4e96721d0872d3d05e109b80b7527c452498..0d18ab8ecc5e2ebf2abe62110c4eeb0db73b4b41 100644
--- a/chrome/browser/net/predictor_browsertest.cc
+++ b/chrome/browser/net/predictor_browsertest.cc
@@ -464,6 +464,8 @@ class PredictorBrowserTest : public InProcessBrowserTest {
switches::kEnableExperimentalWebPlatformFeatures);
command_line->AppendSwitchASCII(
switches::kEnableBlinkFeatures, kBlinkPreconnectFeature);
+ command_line->AppendSwitchASCII(switches::kEnableFeatures,
+ "PreconnectMore");
}
void SetUpOnMainThread() override {
@@ -594,10 +596,13 @@ class PredictorBrowserTest : public InProcessBrowserTest {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
observer_.reset(
new CrossSitePredictorObserver(source_host, cross_site_host));
- BrowserThread::PostTask(
+ base::RunLoop run_loop;
mmenke 2016/05/16 19:10:07 These shouldn't be needed - anything that does any
Charlie Harrison 2016/05/16 19:13:39 Ack. Thanks for the clarification. I'll keep it fo
+ BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,
base::Bind(&PredictorBrowserTest::InstallPredictorObserverOnIOThread,
- base::Unretained(this), base::Unretained(predictor())));
+ base::Unretained(this), base::Unretained(predictor())),
+ run_loop.QuitClosure());
+ run_loop.Run();
}
void InstallPredictorObserverOnIOThread(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698