Prevent chrome.windows.create from moving a tab to another profile

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <limits>
 #include <utility>
@@ skipping 441 matching lines @@
       }
       // Don't let the extension crash the browser or renderers.
       if (ExtensionTabUtil::IsKillURL(url)) {
         error_ = keys::kNoCrashBrowserError;
         return false;
       }
       urls.push_back(url);
     }
   }
 
+  // Decide whether we are opening a normal window or an incognito window.
+  bool is_error = true;
+  bool open_incognito_window =
+      ShouldOpenIncognitoWindow(create_data, &urls, &is_error);
+  if (is_error)
+    return false;  // error_ member is set inside of ShouldOpenIncognitoWindow.
+
+  Profile* window_profile = GetProfile();
+  if (open_incognito_window)
+    window_profile = window_profile->GetOffTheRecordProfile();
+
   // Look for optional tab id.
   if (create_data && create_data->tab_id) {
     // Find the tab. |source_tab_strip| and |tab_index| will later be used to
     // move the tab into the created window.
+    Browser* source_browser = nullptr;
     if (!GetTabById(*create_data->tab_id,
                     GetProfile(),
                     include_incognito(),
-                    NULL,
+                    &source_browser,
                     &source_tab_strip,
-                    NULL,
+                    nullptr,
                     &tab_index,
                     &error_))
       return false;
+
+    if (!source_browser->window()->IsTabStripEditable()) {
+      error_ = keys::kTabStripNotEditableError;
+      return false;
+    }
+
+    if (source_browser->profile() != window_profile) {
+      error_ = keys::kCanOnlyMoveTabsWithinSameProfileError;
+      return false;
+    }
   }
 
   if (!IsValidStateForWindowsCreateFunction(create_data)) {
     error_ = keys::kInvalidWindowStateError;
     return false;
   }
 
-  Profile* window_profile = GetProfile();
   Browser::Type window_type = Browser::TYPE_TABBED;
   bool create_panel = false;
 
   // panel_create_mode only applies if create_panel = true
   PanelManager::CreateMode panel_create_mode = PanelManager::CREATE_AS_DOCKED;
 
   gfx::Rect window_bounds;
   bool focused = true;
   bool saw_focus_key = false;
   std::string extension_id;
 
-  // Decide whether we are opening a normal window or an incognito window.
-  bool is_error = true;
-  bool open_incognito_window = ShouldOpenIncognitoWindow(create_data, &urls,
-                                                         &is_error);
-  if (is_error) {
-    // error_ member variable is set inside of ShouldOpenIncognitoWindow.
-    return false;
-  }
-  if (open_incognito_window) {
-    window_profile = window_profile->GetOffTheRecordProfile();
-  }
-
   if (create_data) {
     // Figure out window type before figuring out bounds so that default
     // bounds can be set according to the window type.
     switch (create_data->type) {
       case windows::CREATE_TYPE_POPUP:
         window_type = Browser::TYPE_POPUP;
         extension_id = extension()->id();
         break;
       case windows::CREATE_TYPE_PANEL:
       case windows::CREATE_TYPE_DETACHED_PANEL: {
@@ skipping 1630 matching lines @@
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
   zoom_settings.default_zoom_factor.reset(new double(
       content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions