Source/web/WebPageSerializerImpl.cpp - Issue 19845004: Do not normalize into NFC the values of form fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPageSerializerImpl.cpp

Issue 19845004: Do not normalize into NFC the values of form fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add normalizeAndEncode() without memory safety problem Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPageSerializerImpl.cpp

diff --git a/Source/web/WebPageSerializerImpl.cpp b/Source/web/WebPageSerializerImpl.cpp

index 0ce48995db162452ab89ba520d64e798351dacc8..38e8a1fc85b7e3e11e01d43d8476f3fc5c259a8e 100644

--- a/Source/web/WebPageSerializerImpl.cpp

+++ b/Source/web/WebPageSerializerImpl.cpp

@@ -285,7 +285,7 @@ void WebPageSerializerImpl::encodeAndFlushBuffer(

String content = m_dataBuffer.toString();

m_dataBuffer.clear();

- CString encodedContent = param->textEncoding.encode(content, WTF::EntitiesForUnencodables);

+ CString encodedContent = param->textEncoding.normalizeAndEncode(content, WTF::EntitiesForUnencodables);

// Send result to the client.

m_client->didSerializeDataForFrame(param->url,

« no previous file with comments | « Source/core/xml/XMLHttpRequest.cpp ('k') | Source/weborigin/KURL.cpp » ('j') | no next file with comments »