Source/core/html/FormDataList.cpp - Issue 19845004: Do not normalize into NFC the values of form fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/FormDataList.cpp

Issue 19845004: Do not normalize into NFC the values of form fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/FormDataList.cpp

diff --git a/Source/core/html/FormDataList.cpp b/Source/core/html/FormDataList.cpp

index 6096a232ad7f06386f4f3b24b8b63ae9e2082d3d..395aaa4386c1314f98f63bae20af7913ba5fe761 100644

--- a/Source/core/html/FormDataList.cpp

+++ b/Source/core/html/FormDataList.cpp

@@ -32,7 +32,7 @@ FormDataList::FormDataList(const WTF::TextEncoding& c)

void FormDataList::appendString(const String& string)

{

- CString encodedString = m_encoding.encode(string, WTF::EntitiesForUnencodables);

+ CString encodedString = m_encoding.encode(string, WTF::NoNormalization, WTF::EntitiesForUnencodables);

m_items.append(normalizeLineEndingsToCRLF(encodedString));

}

« no previous file with comments | « LayoutTests/fast/forms/form-data-encoding-3-expected.txt ('k') | Source/wtf/text/TextCodec.h » ('j') | Source/wtf/text/TextEncoding.h » ('J')