cc: Do not reset pending tree state incorrectly on aborted commits.

cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b63f28f7aa471e911acd108c70b85b4a6c10e132
Cr-Commit-Position: refs/heads/master@{#393943}

[sunnyps, 2016-05-14 00:26:16]

Description was changed from

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=danakj@chromium.org
==========

to

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunnyps, 2016-05-14 00:27:52]

sunnyps@chromium.org changed reviewers:
+ enne@chromium.org

[sunnyps, 2016-05-14 00:27:52]

PTAL

[sunnyps, 2016-05-14 00:28:03]

Description was changed from

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[enne (OOO), 2016-05-16 17:05:41]

lgtm with comment nit

https://codereview.chromium.org/1984453003/diff/1/cc/scheduler/scheduler_stat...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/1984453003/diff/1/cc/scheduler/scheduler_stat...
cc/scheduler/scheduler_state_machine.cc:592: // If the commit was aborted, then
there is no pending tree.
I don't think this comment is true any longer.

[sunnyps, 2016-05-16 19:54:23]

Thanks!

https://codereview.chromium.org/1984453003/diff/1/cc/scheduler/scheduler_stat...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/1984453003/diff/1/cc/scheduler/scheduler_stat...
cc/scheduler/scheduler_state_machine.cc:592: // If the commit was aborted, then
there is no pending tree.
On 2016/05/16 17:05:41, enne wrote:
> I don't think this comment is true any longer.

Done.

[sunnyps, 2016-05-16 19:54:32]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-05-16 19:54:32]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1984453003/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2016-05-16 19:55:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984453003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984453003/20001

[sunnyps, 2016-05-16 19:59:26]

Description was changed from

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-16 20:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 20:35:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunnyps, 2016-05-16 21:29:57]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2016-05-16 21:30:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984453003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984453003/20001

[commit-bot: I haz the power, 2016-05-16 21:50:51]

Description was changed from

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-16 21:50:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 21:52:02]

Description was changed from

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Do not reset pending tree state incorrectly on aborted commits.

When the --enable-main-frame-before-activation flag is passed aborted
commits can cause the pending tree CHECK in LTHI::BeginCommit to fail.
This happens because the aborted commit resets the scheduler's pending
tree state and causes it to start a commit while there's a pending tree.

BUG=606210
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b63f28f7aa471e911acd108c70b85b4a6c10e132
Cr-Commit-Position: refs/heads/master@{#393943}
==========

[commit-bot: I haz the power, 2016-05-16 21:52:03]

Patchset 2 (id:??) landed as
https://crrev.com/b63f28f7aa471e911acd108c70b85b4a6c10e132
Cr-Commit-Position: refs/heads/master@{#393943}