Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1984443002: Manual rebaseline virtual/spv2/fast/overflow/line-clamp.html for Win7 (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
Reviewers:
tapted
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual rebaseline virtual/spv2/fast/overflow/line-clamp.html for Win7 The Auto-rebaseline for r393300 done in r393325 created a separate png for Win7 from Win, but WebKit Win7 fail since then, matching to the image for Win. This patch removes -expected.png for Win7. BUG=610791 TBR=tapted@chromium.org Committed: https://crrev.com/473938b5d45c51d1d50a15af26bcd1ae4b924dfe Cr-Commit-Position: refs/heads/master@{#393748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/virtual/spv2/fast/overflow/line-clamp-expected.png View Binary file 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984443002/1
4 years, 7 months ago (2016-05-14 04:36:38 UTC) #4
kojii
4 years, 7 months ago (2016-05-14 04:37:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 20:34:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 20:36:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/473938b5d45c51d1d50a15af26bcd1ae4b924dfe
Cr-Commit-Position: refs/heads/master@{#393748}

Powered by Google App Engine
This is Rietveld 408576698