mash/public/interfaces/wallpaper.mojom - Issue 1984433002: Hook up Chrome's wallpaper picker for mash.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mash/public/interfaces/wallpaper.mojom

Issue 1984433002: Hook up Chrome's wallpaper picker for mash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gyp builds; address Sadrul's comment. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mash.mojom;

	6

	7 import "skia/public/interfaces/bitmap.mojom";

	8

	9 // Used by Chrome to set the wallpaper displayed by Mash.
	James Cook 2016/05/19 22:30:00 nit: s/Mash/ash_sysui/ (I'm a big fan of documenti nit: s/Mash/ash_sysui/ (I'm a big fan of documenting exactly who uses these interfaces, unless they are something general purpose.) msw 2016/05/20 19:53:05 Done. Show quoted text On 2016/05/19 22:30:00, James Cook wrote: > nit: s/Mash/ash_sysui/ (I'm a big fan of documenting exactly who uses these > interfaces, unless they are something general purpose.) Done.
	10 interface WallpaperController {

	11 SetWallpaper(skia.mojom.Bitmap wallpaper, int32 layout);
	James Cook 2016/05/19 22:30:00 document the layout values document the layout values msw 2016/05/20 19:53:05 Done. Show quoted text On 2016/05/19 22:30:00, James Cook wrote: > document the layout values Done.
	12 };

	13

	14 // Used by Mash to trigger Chrome's wallpaper picker functionality.
	James Cook 2016/05/19 22:30:00 ditto ditto msw 2016/05/20 19:53:05 Done. Show quoted text On 2016/05/19 22:30:00, James Cook wrote: > ditto Done.
	15 interface WallpaperHelper {

	16 OpenWallpaperManager();

	17 };

OLD	NEW