Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 198443003: Rename LiveNodeList::nodeMatches() to elementMatches() (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Rename LiveNodeList::nodeMatches() to elementMatches() Rename LiveNodeList::nodeMatches() to elementMatches() as LiveNodeList only deals with Element items now. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/dom/LiveNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NameNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelsNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/RadioNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
6 years, 9 months ago (2014-03-13 01:38:23 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-13 18:38:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/198443003/1
6 years, 9 months ago (2014-03-13 18:38:58 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 18:39:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-13 18:39:25 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-13 18:47:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/198443003/1
6 years, 9 months ago (2014-03-13 18:47:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 19:32:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-13 19:32:33 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-13 19:42:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/198443003/1
6 years, 9 months ago (2014-03-13 19:42:51 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 22:18:25 UTC) #12
Message was sent while issue was closed. 
Change committed as 169163

Powered by Google App Engine
This is Rietveld 408576698