Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1984403002: Revert of Reland: mus: Add views_mus_interactive_ui_tests target (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: mus: Add views_mus_interactive_ui_tests target (patchset #2 id:20001 of https://codereview.chromium.org/1982963002/ ) Reason for revert: Speculative revert for compile failure on Win: https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/43482 Original issue's description: > Reland: mus: Add views_mus_interactive_ui_tests target > > Previous attempt had a size_t to int warning on Windows, which was suppressed in chrome's interactive_ui_tests but not this new target. See https://codereview.chromium.org/1972363002/ > > * Run widget_interactive_uitests.cc in the new target. > * Added a shared "test_support" target in ui/views/mus. > * Pull ViewsMusTestSuite into its own file so I can share it. > * Also make ViewsTestBase::IsMus static so I can call it before the > PlatformTestHelper is initialized. > * Disable a bunch of tests that fail on mus (I filed bugs for them). > * Fix an unnecessary size_t to int conversion > > BUG=602036 > TEST=views_mus_interactive_ui_tests on mus, interactive_ui_tests elsewhere > TBR=sky@chromium.org, dpranke@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77 > Cr-Commit-Position: refs/heads/master@{#394153} TBR=jamescook@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602036 Committed: https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45 Cr-Commit-Position: refs/heads/master@{#394158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -391 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.mojo.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 5 chunks +20 lines, -89 lines 0 comments Download
M ui/views/mus/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/mus/interactive_ui_tests_manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D ui/views/mus/interactive_ui_tests_mus.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/mus/run_all_unittests_mus.cc View 1 chunk +137 lines, -2 lines 0 comments Download
D ui/views/mus/views_mus_test_suite.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/mus/views_mus_test_suite.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M ui/views/run_all_unittests.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/run_all_unittests.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/platform_test_helper.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/views/test/platform_test_helper.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/test/views_test_base.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 10 chunks +11 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
qyearsley
Created Revert of Reland: mus: Add views_mus_interactive_ui_tests target
4 years, 7 months ago (2016-05-17 17:50:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984403002/1
4 years, 7 months ago (2016-05-17 17:50:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 17:51:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78edbe6407945f0e2c8d1c7dfc873e398150ad45 Cr-Commit-Position: refs/heads/master@{#394158}
4 years, 7 months ago (2016-05-17 17:53:39 UTC) #5
qyearsley
4 years, 7 months ago (2016-05-17 18:00:04 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1990453003/ by qyearsley@chromium.org.

The reason for reverting is: Relanding (this doesn't appear to have caused the
compile failure on Win).

Powered by Google App Engine
This is Rietveld 408576698