Issue 19844006: Revert "Reland r212020: Move Python setup/tear down logic into Forwarder ..."

Issue 19844006: Revert "Reland r212020: Move Python setup/tear down logic into Forwarder ..." (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:

CC:
chromium-reviews, craigdh+watch_chromium.org, kkania, frankf, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Reland r212020: Move Python setup/tear down logic into Forwarder ..." This reverts r212020 which caused some timeouts on the net_unittests every ~15 builds. Conflicts: build/android/pylib/base/test_dispatcher.py build/android/pylib/instrumentation/test_runner.py chrome/test/chromedriver/run_py_tests.py TBR=bulach@chromium.org BUG=262573, 242846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212888

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -256 lines)			Patch
M	build/android/adb_reverse_forwarder.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	build/android/bb_run_sharded_steps.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	build/android/pylib/base/base_test_runner.py	View	4 chunks	+24 lines, -18 lines	0 comments	Download
M	build/android/pylib/base/test_dispatcher.py	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	build/android/pylib/chrome_test_server_spawner.py	View	8 chunks	+11 lines, -6 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View	5 chunks	+82 lines, -211 lines	0 comments	Download
M	build/android/pylib/host_driven/python_test_sharder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/test/chromedriver/run_py_tests.py	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/test_environment.py	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/adb_commands.py	View	2 chunks	+16 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

craigdh

7 years, 5 months ago (2013-07-22 17:49:30 UTC) #2

Message was sent while issue was closed.

On 2013/07/22 15:56:28, Philippe wrote:
> Committed patchset #3 manually as r212888.

r212020 also broke ChromeDriver tests:

Traceback (most recent call last):
  File
"/usr/local/google/b/build/slave/yakju-chrome-driver-tests/build/src/chrome/test/chromedriver/run_py_tests.py",
line 749, in <module>
    ChromeDriverTest.GlobalTearDown()
  File
"/usr/local/google/b/build/slave/yakju-chrome-driver-tests/build/src/chrome/test/chromedriver/run_py_tests.py",
line 153, in GlobalTearDown
    forwarder.Forwarder.UnmapAllDevicePorts(ChromeDriverTest._adb)
  File
"/usr/local/google/b/build/slave/yakju-chrome-driver-tests/build/src/chrome/test/chromedriver/../../../build/android/pylib/forwarder.py",
line 142, in UnmapAllDevicePorts
    for ((device_serial, device_port), _) in port_map:
ValueError: too many values to unpack

Expand Messages | Collapse Messages