Remove webkit/plugins/npapi.

Remove webkit/plugins/npapi.

-NPAPIPluginsSupported moves to PluginService
  -no need to call it in PluginList methods anymore since PluginService is now the only place that calls these methods, and it can check first
  -no need for the renderer to call this first since now the browser won't enumerate NPAPI plugins if it's disabled
-CreateVersionFromString moves to WebPluginInfo. I couldn't find a better place to put it.
-move the constants back to plugin_constants_win.h
-move PLUGIN_QUIRK_DIE_AFTER_UNLOAD handling to WebPluginDelegateStub and PluginThread instead of being a global
-GetDefaultWindowParent moves to plugin_constants_win.h. I couldn't find a better place.
-IsPluginWindow moves to PluginService
-GetPluginNameFromWindow and GetPluginVersionFromWindow are both replaced by GetPluginInfoFromWindow which is on PluginService
-IsDummyActivationWindow was called by one place so I moved the code there

BUG=237249
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212672

[scottmg, 2013-07-19 20:25:00]

https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
File content/browser/plugin_loader_posix.cc (right):

https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
content/browser/plugin_loader_posix.cc:81:
PluginService::NPAPIPluginsSupported());
GetInstance()

https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
File content/common/plugin_constants_win.cc (right):

https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
content/common/plugin_constants_win.cc:29: HWND GetDefaultWindowParent() {
this seems a bit sketchy, how about just plugin_utils_win.cc/h

[jam, 2013-07-19 20:35:21]

https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
File content/browser/plugin_loader_posix.cc (right):

https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
content/browser/plugin_loader_posix.cc:81:
PluginService::NPAPIPluginsSupported());
On 2013/07/19 20:25:01, scottmg wrote:
> GetInstance()

fix on the way

https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
File content/common/plugin_constants_win.cc (right):

https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
content/common/plugin_constants_win.cc:29: HWND GetDefaultWindowParent() {
On 2013/07/19 20:25:01, scottmg wrote:
> this seems a bit sketchy, how about just plugin_utils_win.cc/h

yeah i agree it doesn't look nice. however i'm a bit apprehensive of adding a
new file for one static function! would it be better to rename this file?

[scottmg, 2013-07-19 20:42:16]

On 2013/07/19 20:35:21, jam wrote:
>
https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
> File content/browser/plugin_loader_posix.cc (right):
> 
>
https://codereview.chromium.org/19844003/diff/19001/content/browser/plugin_lo...
> content/browser/plugin_loader_posix.cc:81:
> PluginService::NPAPIPluginsSupported());
> On 2013/07/19 20:25:01, scottmg wrote:
> > GetInstance()
> 
> fix on the way
> 
>
https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
> File content/common/plugin_constants_win.cc (right):
> 
>
https://codereview.chromium.org/19844003/diff/19001/content/common/plugin_con...
> content/common/plugin_constants_win.cc:29: HWND GetDefaultWindowParent() {
> On 2013/07/19 20:25:01, scottmg wrote:
> > this seems a bit sketchy, how about just plugin_utils_win.cc/h
> 
> yeah i agree it doesn't look nice. however i'm a bit apprehensive of adding a
> new file for one static function! would it be better to rename this file?

shrug, i don't it's a big deal to add a file, we've already got lots. :)

alternatively, since it must always because in an OS_WIN block anyway, i'm not
sure the function is adding much information -- you could just call
GetDesktopWindow directly.

[jam, 2013-07-19 20:53:30]

On 2013/07/19 20:42:16, scottmg wrote:
> shrug, i don't it's a big deal to add a file, we've already got lots. :)
> 
> alternatively, since it must always because in an OS_WIN block anyway, i'm not
> sure the function is adding much information -- you could just call
> GetDesktopWindow directly.

ok, that's better, done

[scottmg, 2013-07-19 20:56:04]

lgtm

https://codereview.chromium.org/19844003/diff/9006/content/common/plugin_cons...
File content/common/plugin_constants_win.h (left):

https://codereview.chromium.org/19844003/diff/9006/content/common/plugin_cons...
content/common/plugin_constants_win.h:41: 
\n, or not if you already started tryjobs

[jam, 2013-07-19 21:04:29]

https://codereview.chromium.org/19844003/diff/9006/content/common/plugin_cons...
File content/common/plugin_constants_win.h (left):

https://codereview.chromium.org/19844003/diff/9006/content/common/plugin_cons...
content/common/plugin_constants_win.h:41: 
On 2013/07/19 20:56:04, scottmg wrote:
> \n, or not if you already started tryjobs

will readd locally