initial checkin of SkSL compiler

src/sksl/ir/SkSLFunctionDeclaration.h

Index: src/sksl/ir/SkSLFunctionDeclaration.h
diff --git a/src/sksl/ir/SkSLFunctionDeclaration.h b/src/sksl/ir/SkSLFunctionDeclaration.h
new file mode 100644
index 0000000000000000000000000000000000000000..2c8210135906c08d552bcf605cbf3ecf8e10fe15
--- /dev/null
+++ b/src/sksl/ir/SkSLFunctionDeclaration.h
@@ -0,0 +1,54 @@
+/*
+ * Copyright 2016 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+ 
+#ifndef SKSL_FUNCTIONDECLARATION
+#define SKSL_FUNCTIONDECLARATION
+
+#include "SkSLModifiers.h"
+#include "SkSLSymbol.h"
+#include "SkSLType.h"
+#include "SkSLVariable.h"
+
+namespace SkSL {
+
+/**
+ * A function declaration (not a definition -- does not contain a body).
+ */
+struct FunctionDeclaration : public Symbol {
+    FunctionDeclaration(Position position, std::string name, 
+                        std::vector<std::shared_ptr<Variable>> parameters, 
+                        std::shared_ptr<Type> returnType)
+    : INHERITED(position, kFunctionDeclaration_Kind, std::move(name))
+    , fParameters(parameters)
+    , fReturnType(returnType) {}
+
+    std::string description() const override {
+        std::string result = fReturnType->fName + " " + fName + "(";
+        std::string separator = "";
+        for (auto p : fParameters) {

[dogben, 2016/06/22 17:43:57]

nit: const ref

+            result += separator;
+            separator = ", ";
+            result += p->description();
+        }
+        result += ")";
+        return result;
+    }
+
+    bool matches(std::shared_ptr<FunctionDeclaration> f) {
+        return fName == f->fName && fParameters == f->fParameters;
+    }
+
+    mutable bool fDefined;

[dogben, 2016/06/22 17:43:57]

nit: seems like this doesn't need to be mutable.

[ethannicholas, 2016/06/24 21:23:10]

While you are correct that it isn't needed from a "modifiable via a const
function" standpoint, I wanted to call out that this field (unlike every other
field across all of the IR) violates immutability. Might be silly, but I'm used
to working in languages with first-class immutability and wanted to be explicit
about it...

+    const std::vector<std::shared_ptr<Variable>> fParameters;
+    const std::shared_ptr<Type> fReturnType;
+
+    typedef Symbol INHERITED;
+};
+
+} // namespace
+
+#endif