Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: src/sksl/ir/SkSLConstructor.h

Issue 1984363002: initial checkin of SkSL compiler (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: more cleanups Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/sksl/ir/SkSLConstructor.h
diff --git a/src/sksl/ir/SkSLConstructor.h b/src/sksl/ir/SkSLConstructor.h
new file mode 100644
index 0000000000000000000000000000000000000000..428cdb1ecfee13989a55cae6268099aa77765aa7
--- /dev/null
+++ b/src/sksl/ir/SkSLConstructor.h
@@ -0,0 +1,52 @@
+/*
+ * Copyright 2016 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef SKSL_CONSTRUCTOR
+#define SKSL_CONSTRUCTOR
+
+#include "SkSLExpression.h"
+
+namespace SkSL {
+
+/**
+ * Represents the construction of a compound type, such as "vec2(x, y)".
+ */
+struct Constructor : public Expression {
+ Constructor(Position position, std::shared_ptr<Type> type,
+ std::vector<std::unique_ptr<Expression>> parameters)
dogben 2016/06/22 17:43:57 nit: s/parameters/arguments/g
ethannicholas 2016/06/24 21:23:09 Wow. I had always thought those were interchangeab
dogben 2016/06/26 03:57:53 In 99% of contexts, I use them interchangeably. It
+ : INHERITED(position, kConstructor_Kind, type)
dogben 2016/06/22 17:43:57 nit: std::move
+ , fParameters(std::move(parameters)) {}
+
+ virtual std::string description() const override {
dogben 2016/06/22 17:43:57 nit: remove virtual
+ std::string result = fType->description() + "(";
+ std::string separator = "";
+ for (size_t i = 0; i < fParameters.size(); i++) {
+ result += separator;
+ result += fParameters[i]->description();
+ separator = ", ";
+ }
+ result += ")";
+ return result;
+ }
+
+ bool isConstant() const override {
+ for (size_t i = 0; i < fParameters.size(); i++) {
+ if (!fParameters[i]->isConstant()) {
+ return false;
+ }
+ }
+ return true;
+ }
+
+ const std::vector<std::unique_ptr<Expression>> fParameters;
+
+ typedef Expression INHERITED;
+};
+
+} // namespace
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698