Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: src/sksl/ir/SkSLFunctionCall.h

Issue 1984363002: initial checkin of SkSL compiler (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: more cleanups Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #ifndef SKSL_FUNCTIONCALL
9 #define SKSL_FUNCTIONCALL
10
11 #include "SkSLExpression.h"
12 #include "SkSLFunctionDeclaration.h"
13
14 namespace SkSL {
15
16 /**
17 * A function invocation.
18 */
19 struct FunctionCall : public Expression {
20 FunctionCall(Position position, std::shared_ptr<FunctionDeclaration> functio n,
dogben 2016/06/22 17:43:57 Checking my understanding: Reading the GLSL spec,
ethannicholas 2016/06/24 21:23:10 Correct.
21 std::vector<std::unique_ptr<Expression>> parameters)
dogben 2016/06/22 17:43:57 nit: s/parameters/arguments/g
22 : INHERITED(position, kFunctionCall_Kind, function->fReturnType)
23 , fFunction(function)
dogben 2016/06/22 17:43:57 nit: std::move
24 , fParameters(std::move(parameters)) {}
25
26 virtual std::string description() const override {
dogben 2016/06/22 17:43:57 nit: remove virtual
27 std::string result = fFunction->fName + "(";
28 std::string separator = "";
29 for (size_t i = 0; i < fParameters.size(); i++) {
30 result += separator;
31 result += fParameters[i]->description();
32 separator = ", ";
33 }
34 result += ")";
35 return result;
36 }
37
38 const std::shared_ptr<FunctionDeclaration> fFunction;
39 const std::vector<std::unique_ptr<Expression>> fParameters;
40
41 typedef Expression INHERITED;
42 };
43
44 } // namespace
45
46 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698