Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: src/sksl/ast/SkSLASTDeclaration.h

Issue 1984363002: initial checkin of SkSL compiler (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: cleanups Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #ifndef SKSL_ASTDECLARATION
9 #define SKSL_ASTDECLARATION
10
11 #include "SkSLASTPositionNode.h"
12
13 namespace SkSL {
14
15 /**
16 * Abstract supertype of declarations such as variables and functions.
17 */
18 struct ASTDeclaration : public ASTPositionNode {
19 enum Kind {
dogben 2016/06/20 16:23:17 nit: In the context of a compiler, "Kind" seems li
ethannicholas 2016/06/20 17:45:49 "Type" is even more overloaded :-). Is there a bet
dogben 2016/06/20 18:26:26 Where you use "Kind" to enumerate subclasses, I wo
ethannicholas 2016/06/20 20:17:10 Unless you've got a major objection, I'd prefer to
20 kVar_Kind,
21 kFunction_Kind,
22 kInterfaceBlock_Kind,
23 kExtension_Kind
24 };
25
26 ASTDeclaration(Position position, Kind kind)
27 : INHERITED(position)
28 , fKind(kind) {}
29
30 Kind fKind;
31
32 typedef ASTPositionNode INHERITED;
33 };
34
35 } // namespace
36
37 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698